[Libreoffice-bugs] [Bug 133529] calc: ui: filesave: conflict between sort and filter, unclear use of tag 'table:orientation'

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=133529

--- Comment #7 from b. <newbie-02 at gmx.de> ---
i'll try to requeue the patch i tried for tdf#133336, i didn't yet find a
better solution and would like some progress ... 

i've outcommented the bIsSortedColumns check in
test/sort/sheet/xdatabaserange.cxx as i see no use case for it, but some other
improving with the patch, 

the patch contains a long comment describing the situation and improvement,
it's not neccessary, i'm hoping it'll help against hasty "not okay" verdicts,  

i'd be happy about a careful review, 

the basic error, conflict between sort and filter, can probably only be
corrected by changing the tdf standard, or by changing the application of the
standard by calc, 

some use cases are better with the patch than without, no use cases are
worsened, see list below, 

i checked: proposal for sort orientation, proposal for sort field, filter
correct in gui, filter.field values correct for basic, tag 'table:orientation'
in content.xml file, property table:field-number in content.xml, for creating,
saving, reload, re-save and re-re-load of: a databaserange without sort or
filter applied, a databaserange with an active filter, a databaserange fresh
sorted vertically, a databaserange fresh sorted horizontally, a databaserange
first filtered and then sorted vertically, a databaserange first filtered and
then sorted horizontally, a databaserange first sorted vertically and then
filtered, a databaserange first sorted horizontally and then filtered, 

comparison with patch - without patch: 
number - use case - runtime - first save - reload - second save - reload

without patch: 
1. - dbrange - ok - ok - !ok - !ok - !ok (proposal for sort: horizontal/tag
"column"), 
2. - dbrange+filter - ok - ok - !ok - !ok - !ok (orientation/tag
"column"/.field values), 
3. - dbrange+sort-vertical - ok - ok - ok - ok - ok, 
4. - dbrange+sort-horizontal - ok - ok - ok - ok - ok, 
5. - dbrange+1filter+2sort-vertical - ok - ok - ok - ok - ok, 
6. - dbrange+1filter+2sort-horizontal - !ok - !ok - !ok - !ok - !ok
(orientation/tag "column"/.field values), 
7. - dbrange+1sort-vertical+2filter - ok - ok - ok - ok - ok, 
8. - dbrange+1sort-horizontal+2filter - !ok - !ok - !ok - !ok - !ok (proposal
for sort messed/no tag orientation), 

with patch: 
9. - dbrange - ok - ok - ok - ok - ok, 
10. - dbrange+filter - ok - ok - ok - ok - ok, 
11. - dbrange+sort-vertical - ok - ok - ok - ok - ok, 
12. - dbrange+sort-horizontal - ok - ok - ok - ok - ok, 
13. - dbrange+1filter+2sort-vertical - ok - ok - ok - ok - ok, 
14. - dbrange+1filter+2sort-horizontal - !ok - !ok - !ok - !ok - !ok (filter:
orientation/tag "column"/.field values), 
15. - dbrange+1sort-vertical+2filter - ok - ok - ok - ok - ok, 
16th - dbrange+1sort-horizontal+2filter - !ok - !ok - !ok - !ok - !ok (sort:
proposal for sort messed/no tag orientation), 

problems can still occur with a - wrong? - use of table:orientation for
'eastern languages' (right to left or bottom to top?), i have no knowledge
about this, 

reg. 

b.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200608/3b0683ff/attachment.htm>