[Libreoffice-bugs] [Bug 133673] LibreOffice fails to refresh Locks when using WebDAV with Authorization

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=133673

--- Comment #3 from Julian Kalinowski <Julian.Kalinowski at dataport.de> ---
I tried to dig into this bug and found that my log of the failed LOCK request
is not sufficient.
What happens before that is actually relevant: I have a failed PROPFIND Request
(HTTP 500 Internal Server Error), which is handled by
NeonSession.HandleError():
https://git.libreoffice.org/core/+/refs/heads/master/ucb/source/ucp/webdav-neon/NeonSession.cxx#1826
I'll attach a new logfile where you can see the failed request before the lock
refresh.

There, the RequestEnvironment is reset.
However, when refreshing Locks as in NeonLockStore, the session is re-used. So
now, when the NeonAuth Callback is called by neon, it will fail in this line:
https://git.libreoffice.org/core/+/refs/heads/master/ucb/source/ucp/webdav-neon/NeonSession.cxx#285
because there is no DAVAuthListener registered anymore.
For all other cases, this is not a problem as calls to NeonSession typically
provide a new RequestEnvironment - but refreshing locks does not.

I'm going to investigate why the internal server error appears at all, but i
think this also is a bug in LibreOffice.
When sessions are re-used, the DAVAuthListener must not be cleared in
HandleError.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200609/e3faa5c7/attachment-0001.htm>