[Libreoffice-bugs] [Bug 133673] LibreOffice fails to refresh Locks when using WebDAV with Authorization

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=133673

--- Comment #5 from Julian Kalinowski <Julian.Kalinowski at dataport.de> ---
Another clarification:
HandleError is called regardless whether there was an error, so the
RequestEnvironment is reset in any case and will be missing when refreshing
locks.
This may only affect Authorization Types NTLM and Negotiate, because for those,
the AuthListener is called after a 401. For Digest Authentication, credentials
are cached in the session and re-used, so no 401 will occur.

Possible solutions IMHO:
1. Don't reset RequestEnvironment (m_aEnv in NeonSession). Should work as it is
reset by all NeonSession methods anyway - except the LOCK() method for
refreshing locks.

2. Don't reset the whole RequestEnvironment, but instead exclude the
AuthListener as it is obviously needed again. Maybe AuthListener shouldn't be a
part of RequestEnvironment at all?

3. Set RequestEnvironment when refreshing locks. As this is done within
NeonLockStore, it somehow needs a reference to the AuthListener, which is
usually set by DAVResourceAccess. It could cache it somewhere but this doesn't
seem like a valid idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200610/22565c42/attachment.htm>