[Libreoffice-bugs] [Bug 128353] Impress: Animated GIF and WMV do not play anymore

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=128353

--- Comment #15 from Telesto <telesto at surfxs.nl> ---
Created attachment 161856
  --> https://bugs.documentfoundation.org/attachment.cgi?id=161856&action=edit
Bibisect log

Bisected to non playing WMV in GDI mode to:
author  Miklos Vajna <vmiklos at collabora.com>    2019-04-17 11:38:47 +0200
committer       Miklos Vajna <vmiklos at collabora.com>    2019-04-17 15:43:48
+0200
commit  d7f4f5650dd2c7fe1ccec50efd806e695b8bc18a (patch)
tree    dac2ee1da1119fe1b1d6ac13f21005847d0ea5d8
parent  0fb575b34d039f7c732820467b6db6f8cebd485d (diff)
tdf#124756 slideshow: avoid mbPaintDisabled for media windows
Commit 3e0092031b73bad107e3122d5d4be2f5bd487744 (tdf#112318 sd opengl:
fix lack of initial animation, 2019-04-05) enabled processing of idle
events between two updates of the slideshow to help OpenGL, which
uncovered a problem with media shapes.

On one hand,
slideshow::internal::ViewMediaShape::implInitializePlayerWindow() calls
EnablePaint(false) on the media window. OTOH,
vcl::Window::ImplCallPaint() handles mbPaintDisabled by invalidating the
relevant area of the window, which causes a paint<->invalidate loop.

Fix the problem by nominally still enabling paints on the media window:
nothing will change in practice (since the actual media overlay will be
on top of it), but this way the loop goes away.

mbPaintDisabled is handled like this since the initial import, the media
window flag was added much later, so it makes more sense to adapt the
later.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=d7f4f5650dd2c7fe1ccec50efd806e695b8bc18a

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200610/ef91428d/attachment.htm>