[Libreoffice-bugs] [Bug 134052] FILEOPEN PPTX: shadow appears solid instead of blurry in presentation mode

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=134052

--- Comment #11 from ahmad_g <ganzouri97 at gmail.com> ---
(In reply to Xisco Faulí from comment #10)
> (In reply to ahmad_g from comment #7)
> > The pptx file I made in MS PowerPoint with a blurry shadow and used it for
> > testing the import of the blur radius.
> > 
> > I've already made a unit test for importing the radius here:
> > https://opengrok.libreoffice.org/xref/core/sd/qa/unit/import-tests.
> > cxx?r=88a5f776#3124
> > 
> > to check that I've got it correct but not available to be seen yet.
> > 
> > Then Later I've created process function which is responsible to create the
> > blurring effect on the shadow of the shape and view it.
> > 
> > Here's the function that resolved the bug:
> > https://opengrok.libreoffice.org/xref/core/drawinglayer/source/processor2d/
> > vclpixelprocessor2d.cxx?r=b435c4fe#1077
> > 
> > Now, it's available to see the blurring shadow as part of my GSoC project
> 
> Hello ahmad, thanks for the great work here!

Thank you!

> I believe
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=b435c4fe82e77a82fde6464d6722281e5fc4f394 was submitted right after your
> wrote those unittests, thus there's no unittest covering this issue, isn't
> it ?

Yes, the process function was submitted after the import unit test. I am still
working on the blurring of the shadow. 

What kind of unit test that covers this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200618/2e255bc0/attachment.htm>