[Libreoffice-bugs] [Bug 38093] Add an Outline View layout and editing mode to Writer

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=38093

--- Comment #125 from Jim Raykowski <raykowj at gmail.com> ---
(In reply to Heiko Tietze from comment #124)
> Tested https://gerrit.libreoffice.org/c/core/+/96672 and found a few more
> "issues".
> 
> First, if a chapter has no content folding is not possible. But I guess
> something like "1.<Heading> 1.1<Subheading> <some text>" is common and users
> would like to fold the complete chapter. 

Nothing coming to me right off the top of my head for handling this case using
the canvas buttons interface, but sub menu items in the Navigator headings
context menu 'Outline Content Visibility' can be used to do this.


>Please check what happens when you
> delete the single paragraph after the folded chapter. For example 1.Foo /n
> Test /n 1.1.Bar /n Lorem ipsum. When I delete the paragraph break after Foo
> in folded state the application crashes.
> 

Assuming you are using the delete key to delete the paragraph, an assert is
failing.

core/sw/source/core/text/txtfrm.cxx:1249: TextFrameIndex
SwTextFrame::MapModelToView(const SwTextNode*, sal_Int32) const: Assertion
`static_cast<SwTextNode*>(const_cast<SwModify*>(SwFrame::GetDep())) == pNode'
failed.

This also happens when left or right arrows are used to move past folded
content. Initially I removed the assert as I could see no ill affects by doing
so but have been advised to not remove it. I think with a non debug build this
does not happen. This is something that requires higher knowledge of what
badness may occur.

> That brings me to the second point: I miss key handling or some key+mouse
> interaction (not least since the delay is a bit long for my taste). How
> about toggle all on ctrl+click at the heading text and not only at the
> button? Alternatively an interaction at the Navigator might be also good.
>

How about making the delay half of what it is now before collapse button is
shown? Collapse button grabs focus on display so you should be able to use the
Space key to fold content or the Enter key to fold content including and sub
levels initially after it is shown. So the code from the ctrl+click patch to do
visibility toggle when mouse pointer is clicked on outline heading should be
added?

> And less of a taste thing, if you disable the "Show outline visibility"
> option while a chapter is folded there is no way to get it back. The unfold
> icon/button must not be hidden by the function.

Navigator heading context menu for outlines with folded content can be used to
show the content. Also the UNO .uno:togglecontentvisiblity can be used. Perhaps
if the 'Show outline visibility button' option is switched off all currently
folded outline content should be shown?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200620/3d8c2cae/attachment-0001.htm>