[Libreoffice-bugs] [Bug 130460] LibreOffice installer reboots Windows10 machines and destroys all open documents without any safeguard

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=130460

--- Comment #4 from Mike Kaganski <mikekaganski at hotmail.com> ---
(In reply to adam.m.s.martin+libreoffice from comment #0)
> Long description:
> 
> ...
> 3. Installer then DEMANDED it reboot the computer
> 4. The dialog box in installer asked "will you reboot later?", the first
> time so I said Yes, I'll reboot later
> 5. The dialog box came back a second time (problem 1: this should not
> happen, I had already answered the question), asking about rebooting later,
> so I hit Yes.
> 6. It turns out that the second dialog box is reworded to have the opposite
> internal meaning (problem 2: this dialog box is over-complicated with bad
> use of English. Instead of the options "Yes" and "No", it should have
> options "DELETE ALL DATA", and "Cancel", since one of the buttons is usually
> guaranteed to cause dataloss)

Oh it's always sad to see people not even trying to read, then claim others to
be guilty...

When the installer detects that some process(es) for some reason block
resources it needs to update, it checks if it is possible to use Windows
Restart Manager service to restart this process. If it is possible, the
installer shows this dialog:

====================
The following applications are using files that need to be updated by this
setup. You can let Installation Wizard close them and attempt to restart them
or reboot the machine later."

[list of processes blocking resources]

() Close the applications and attempt to restart them.
() Do not close applications. A reboot will be required.

[OK] [Cancel]
====================

If it cannot close that process using Windows Restart Manager service, it asks
this question:

====================
The setup must update files or services that cannot be updated while the system
is running. If you choose to continue, a reboot will be required to complete
the setup.

[OK] [Cancel]
====================

In both cases, if user chose to restart later, it proceeds to install, and when
it's finished what was possible to do before reboot, it shows this:

====================
You must restart your system for the configuration changes made to LibreOffice
6.4.2.2 to take effect. Click Yes to restart now or No if you plan to restart
later.

[Yes] [No]
====================

So much attention was paid to make the wording in the dialog shown initially
clear that if one chooses to proceed (without closing and restarting the
blocking process), a restart would be required when installation finishes; and
when it finishes, the message tries hard to make it clear. It even has
*different* buttons: [Yes] and [No] instead of radio buttons and [OK] [Cancel].
But no matter how hard you try, you cannot persuade users to read it when users
like to believe they know what is there without reading. And - well, even *if*
we could change buttons in the dialog (which we can't: it only allows us to
change wording of the message), personally for myself, seeing the proposed
[DELETE ALL DATA] instead of [Yes] would be offensive, trying to demean me.

There's one more thing: while the wording is (partially) controlled by
installer database (MSI), the behaviour itself is controlled by *Windows system
service* named "Windows Installer" (msiexec), which itself does all the magic
to detect the processes blocking updated files (list of which is taken from
MSI); if it's possible to use Restart Manager; and *how to perform the reboot*
when user agrees to reboot (which means, that it's not LibreOffice that decides
to reboot "aggressively" and without "are you sure?", but system service, and
that it's how Microsoft deems it conforming to its system philosophy).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200314/561cdd0b/attachment-0001.htm>