[Libreoffice-bugs] [Bug 132605] Connector dialog does not allow negative value for Line Skew

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=132605

--- Comment #3 from Regina Henschel <rb.henschel at t-online.de> ---
(In reply to Julien Nabet from comment #2)
> We may change the range here:
> cui/source/tabpages/connect.cxx in SvxConnectionPage::SvxConnectionPage
> eg by adding : m_xMtrFldLine2->set_range(-5000, 5000, eFUnit);
> 
> What should be the range for:
> Line 1 / Line 2 / Line 3 for Line Skew

Fix values are not suitable because the used paper sizes in Draw have a wide
range. The fields needs to consider page width/height, -max(width,height) to
+max(width,height) perhaps. But I don't know where the restriction to existing
coordinates are done. Problematic are banner-like paper formats of e.g 6m x
0.5m.

> and
> Begin horizontal / End horizontal / Begin vertical / End vertical for Line
> Spacing

That is difficult. ODF has non-negative values here. But AOO allows negative
values. It would be save to stick to non-negative values and extend to negative
values (which requires "extended" on file save) only on concrete user request.
The range is currently 0cm to 10cm. I would change it only on concrete user
request. I think, that users, who know to use the dialog, are not beginners and
are able to write a bug report.

> 
> Also, I noticed that when changing connector several times the
> enable/disable process for Line Skew seems buggy (sometimes an item stays
> disabled). I'd like to have your opinion before submitting a new bugtracker.

You mean changing the connector type? Line Skew is in ODF only defined for
connector type "standard". There should be a field for each currently drawn
line segment (besides start and end segment). If you can reliable reproduce,
that fields in Line Skew do not correspond to the handles for a connector of
type "standard", then it is a bug, which should be reported.

For other line types it is difficult, because the way LibreOffice uses the Line
Skew fields is not ODF conform. To get that corrected, larger changes than
correcting the dialog would be needed. One problem for example: The handles of
connector type "Line" are used to change length of start and end segment. For
dragging in UI that would be possible, but the values currently go to Line
Skew, whereas they have to go to Line Spacing.

[Connector routing is a night mare. Have a look at the two methods
SdrEdgeObj::ImpCalcEdgeTrack in svdoegde.cxx and the comments therein.]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200502/06b30bff/attachment.htm>