[Libreoffice-bugs] [Bug 132581] UI: Table Text Flow Break shows only 1 radio button. Should be 2

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=132581

Telesto <telesto at surfxs.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|7.0.0.0.alpha0+ Master      |6.4.0.3 release
                 CC|                            |xiscofauli at libreoffice.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
           Keywords|                            |bibisected, bisected,
                   |                            |regression
            Summary|UI: Table Text Flow Break   |UI: Table Text Flow Break
                   |shows only 1 option button. |shows only 1 radio button.
                   |Should be 2                 |Should be 2

--- Comment #1 from Telesto <telesto at surfxs.nl> ---
Bisected to: 
author  Justin Luth <justin.luth at collabora.com> 2019-06-15 22:15:32 +0300
committer       Justin Luth <justin_luth at sil.org>       2019-06-27 06:09:43
+0200
commit  d35171456bc230efdaa9426da1398b2db7fa0df8 (patch)
tree    d2d6956c06a9b64c227d55aa423feaab8175e2bf
parent  ae823e4633a76d13cebc6432b9e44b9b2862326b (diff)
tdf#125609c10 vcl/button: enforce only one radio selected on init
This patch does not solve the main LO 6.2 problem in bug 125609,
but fixes the related problem from comments 10/11.

This patch fixes two different scenarios:
1.) Sometimes buttons could fall through the other safety nets and
have multiple radio buttons selected in a single group at display time.
Since ImplInitStyle can be called multiple times for the same
button, ensure that once everything is imported (IsRadioCheckEnabled)
that any calls to this double-check that only one button is enabled.

First come, first served if by programmer error multiple are marked as
IsChecked in the same group. This problem existed pre-LO 6.2,
so it had nothing to do with tabstops specifically.

2.) This patch specifically fixes the 6.2 regression with the
Grammalecte extension Graphic Options dialog box. In this case
Dialog::GrabFocusToFirstControl ended up being treated as a "click"
on a tabstopped, unchecked radio, because setting the state
never called the SetState/Checked function, but only the Init,
and so the uncheckAllOther function never removed any tabstops.


https://cgit.freedesktop.org/libreoffice/core/commit/?id=d35171456bc230efdaa9426da1398b2db7fa0df8

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200503/5e0a37fd/attachment.htm>