[Libreoffice-bugs] [Bug 130108] FILESAVE XLSX Conditional Format not applied

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=130108

Caolán McNamara <caolanm at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|libreoffice-bugs at lists.free |caolanm at redhat.com
                   |desktop.org                 |

--- Comment #18 from Caolán McNamara <caolanm at redhat.com> ---
SfxStyleSheetBase* pStyle =
rRoot.GetDoc().GetStyleSheetPool()->Find(aStyleName)

that "Find" turns into

SfxStyleSheetBase*          Find(const OUString& rStr)                          
{ return Find(rStr, nSearchFamily, nMask); }

i.e. uses the nSearchFamily and nMask set in the SfxStyleSheetBasePool
and I think that's basically arbitrary depending on whoever last used the
SfxStyleSheetBasePool and called SetSearchMask etc on it.

If we used...

SfxStyleSheetBase* pStyle =
rRoot.GetDoc().GetStyleSheetPool()->Find(aStyleName, SfxStyleFamily::Para)
(like ScTable::CopyConditionalFormat does) then we'd get the 

virtual SfxStyleSheetBase*  Find( const OUString&, SfxStyleFamily eFam,
SfxStyleSearchBits n=SfxStyleSearchBits::All );

variant, which has "All" set as the default 3rd arg

which sort of explains how the bisect could identify a seemingly unrelated
commit which probably changed the timing of setting the arbitrary
SfxStyleSheetBasePool values which got reused by the export and why it could
happen in other cases prior to that

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200503/73339c48/attachment-0001.htm>