[Libreoffice-bugs] [Bug 133040] Undo/redo includes creating of paragraph/character style

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=133040

Telesto <telesto at surfxs.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needsUXEval
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |---

--- Comment #2 from Telesto <telesto at surfxs.nl> ---
@Heiko
Lets reopen this one.. for small UX inquiry; challenging the current situation

I generally separate styles from document changes. Yes, styles are included in
the document; and a relevant for formatting. But creating a style has nothing
to do with the document itself (as long as not applied). Same thing is true for
deleting a non-active style or changing a non-active style. 

In document changes only occur deleting an active style and changing an active
style.

Currently everything is included in the document Undo/Redo system. The
creation/deletion/changing of an style.. 

However, there are number of 'flaws'
* An active document style is can be delete - after warning. The undo restores
the style, but not places where it was used (The warning suggests this
already). Point is about undo being somewhat pointless.
* The redo bit buggy: bug 133041
* Inconsistent: Drag child styles to a different parent is not included in
undo/redo (and changes the formatting a lot)
* The undo of the creation of a style can be counter productive.. Say I create
a style, and want to undo some changes I made before creating the style .. Not
possible without losing the style
* Undo/redo of style change is mostly not an option after in documents edits
are made
* Undo/redo doesn't make sense if there where multiple style changes and you
want to undo an older change.

The only case for undo/redo is the situation where you're fiddling with the
style.. and want to check how it looks.. If not as expect, you press CTRL+Z (of
course not me, as I didn't expect styles being included in undo/redo at the
first place..)

So, in my view it 
(a) would make sense to disable undo/redo in general for styles changes
(b) And if there should be Undo/redo for styles.. in general.. separate it from
the 'general' undo/redo. 
(c) if this is not possible restrict undo/redo to changes of (active) styles.. 

For the record: 'applying an style' a style to a paragraph/character is still
an in document change. It's about mutations related to the styles as such.

I'm aware this being long time behavior.. so there are probably some workflows
relying the current undo/redo.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200515/2ad8332d/attachment-0001.htm>