[Libreoffice-bugs] [Bug 133336] calc: fileopen: filter: irregular reading and saving of filter definitions in ods format affecting all filters

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=133336

--- Comment #9 from b. <newbie-02 at gmx.de> ---
@all: 

could you please check if the following patch fixes this bug, it's 'only' a
change of the 'preset?' of bByRow from 'false' to 'true' in xmldrani.cxx,
sounds logic for me, bByRow 'false' while 'row' is default is somewhat odd, 

i did some tests, looks good, but please! check also affects to other things
like sort, horizontal sort, oriental table orientations etc.,  

and if the patch is ok tell me how to place it as a commit? thanks in advance, 

[LO-main-dir]/sc/source/filter/xml/xmldrani.cxx:

107c107,116
<     bByRow(false),
---
>     // bs-edit: the following is an attempt to solve the wrong applied filter conditions on reload of files saved in *.ods format with active filters, 
>     // bs-edit: see tdf #133336, please recheck!!!, affects only some files where the database range has asymmetric start (off from A1-B2-C3-D4-E5-F6 ...), 
>     // bs-edit: there are oddities left, as without this patch the .field values for the filterdescriptor have been wrong from the first reload on, 
>     // bs-edit: they are now still for load of 'prior-patch' 'second and subsequent' saves, i've not yet checked if old files are 'healed' on new save, 
>     // bs-edit: some affected files may be spotted by negative values for .fields, some more by the tag 'table-orientation="column"', but that may be correct for some of them, 
>     // bs-edit: for the gui access it looks as if the tag 'table-orientation="column"' and the wrong .field values cancel each other out as well with or without the patch, 
>     // bs-edit: the patch is intended to apply from ver. 7.0 on, backport to old ver.?, if the patch holds these comments should be removed starting with ver. 9.0, !!FIXME-9.0!!
>     // bs-edit: original was: bByRow(false),
>     // bs-edit: test: 
>     bByRow(true),

sorry if any mistakes, it's new territory for me ... 

reference for checks in the code: if i'm right last correct version was
3.5.1.2, and bug started in 3.5.2.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200528/9ba62043/attachment.htm>