[Libreoffice-bugs] [Bug 130719] Overwriting Writer styles does not overwrite changes to Marginalia paragraph style

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=130719

--- Comment #28 from Mike Kaganski <mikekaganski at hotmail.com> ---
(In reply to sdc.blanco from comment #27)
> 1.  Open new file1.
> 2.  Modify Heading 1 and 3, and Marginalia
> 3.  Apply Marginalia in file1
> 3.  Save file1.
> 4.  Open new file2, and Modify Heading 2 style.
> 5.  "load styles" to file2 from file1 (with overwrite)
> 
> I got the impression -- from the discussions -- that the result should be:
> Heading 1, 3, and Marginalia styles (from file1) are loaded, while Heading 2
> (from file1) will overwrite the modified Heading 2 in file2.
> 
> In my experiments, Heading 1, 3, and Marginalia are loaded, but Heading 2
> (in file2) is unchanged. Is that how it is supposed to work? according to
> design?  

1-3. This produces a file1 which has "Heading 1", "Heading 3", and "Marginalia"
styles (3 styles in total) explicitly defined in it for sure. All 3 are
modified from defaults; and "Marginalia" is additionally used (so it has two
reasons to be in the files). Other styles (including "Heading 2") are not
changed from initial state; by default, if you have created the file1 from a
default template or from no template, it will mean that "Heading 2" is not
different from program built-in defaults, not used in the file1, and thus not
explicitly defined in the file1.

4. This made file2 with a single modified style "Heading 2".

5. When loading styles from file1, those styles that were in it ("Heading 1",
"Heading 3", and "Marginalia", but *not* "Heading 2" which was absent in file1)
got (re-)defined in file2.

I don't wee where is the difference wrt what we discussed previously.

===

There should no difference between template and normal document IIUC. I don't
think that word "limited" is correct in your sentence "only a limited subset of
common styles and/or styles modified from a default will be loaded". Limited by
what or whom? It's naturally limited by the list of styles explicitly present
in the source file, but "limited" in your sentence doesn't sound like referring
to that natural limit (which doesn't need that qualification). Then, "a" in "a
default" - we actually are talking about *the* default in the program, not "a"
default in unknown place. And this makes it necessary to keep clear distinction
between *the defaults built in the program* (*not* related to *any* template),
and *a template* (just another kind of document which may contain arbitrary
definitions of some styles).

The overwriting applies to the cases when both source and destination contains
a style with the same name. Any kind of style - from the categories checked in
the dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201108/05e73ece/attachment-0001.htm>