[Libreoffice-bugs] [Bug 138524] Crash: Change User Interface mode on inserted OLE object.

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=138524

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kainz.a at gmail.com
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #3 from Julien Nabet <serval2412 at yahoo.fr> ---
After some debugging, the root cause is in
sfx2/source/notebookbar/SfxNotebookBar.cxx here:
OUString sFile = lcl_getNotebookbarFileName( eApp );
See
https://opengrok.libreoffice.org/xref/core/sfx2/source/notebookbar/SfxNotebookBar.cxx?r=d5552b8b#345
    345         OUString sFile = lcl_getNotebookbarFileName( eApp );
=> sFile = "Sidebar"
    346         OUString sNewFile = rUIFile + sFile;
=> sNewFile=modules/simpress/ui/Sidebar
    347         OUString sCurrentFile;
    348         VclPtr<NotebookBar> pNotebookBar =
pSysWindow->GetNotebookBar();
    349         if ( pNotebookBar )
    350             sCurrentFile = pNotebookBar->GetUIFilePath();
=> sCurrentFile=modules/scalc/ui/notebookbar.ui
    351 
    352         bool bChangedFile = sNewFile != sCurrentFile;
=> bChangedFile = true
    353 
    354         if ((!sFile.isEmpty() && bChangedFile) || !pNotebookBar ||
!pNotebookBar->IsVisible()
    355             || bReloadNotebookbar ||
comphelper::LibreOfficeKit::isActive())
    356         {
...
    372             OUString aBuf = rUIFile + sFile;
=> aBuf=modules/simpress/ui/Sidebar (why not reusing sNewFile?)
...
    390             pSysWindow->SetNotebookBar(aBuf, xFrame,
aNotebookBarAddonsItem , bReloadNotebookbar);
=> crash because SetNotebookBar expects a ui file

However not sure what's the right thing to do, return false after line 345 is
sFile doesn't start with notebookbar (since there are several ui files:
notebookbar.ui, notebookbar_compact.ui, notebookbar_groupedbar_full.ui, etc.)?

Andreas: any thoughts here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201128/d91d66fc/attachment-0001.htm>