[Libreoffice-bugs] [Bug 138173] Find and Replace dialog default should other options be closed, unless diacritics is off or any other option is on

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=138173

--- Comment #10 from V Stuart Foote <vstuart.foote at utsa.edu> ---
(In reply to Justin L from comment #9)
> Or you could just move the diacritics option into the upper part - above the
> more options, so that it can never be hidden.

It does not need to be moved (but if so, the other ICU transliteration controls
would need to be kept with it).

Otherwise the expose/display logic for expanding the 'Other options' panel in
the dialog is what needs to be adjusted.

The expanded state is because the 'Diacritics-sensitive' is required to be
enabled by default [1], disabling it is non-performant. And a change from that
default, to unchecked, is what should trigger exposing the 'Other options'--not
the presence of a single checked option as now. 

That could be a test for each of the options for each of the language
modes--but that seems excessive. So probably keep it simple and just check the
state of the diacritic-sensitive (all modes) and the kashida-sensitive (for CTL
mode).

Eike included some comments in the ref commit.

=-ref-=
[1] https://gerrit.libreoffice.org/c/core/+/51382/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201128/1a73879e/attachment.htm>