[Libreoffice-bugs] [Bug 46579] Form fields 'Image Button' do not work in Forms

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=46579

--- Comment #17 from Julien Nabet <serval2412 at yahoo.fr> ---
Lionel: following Robert's comment about using ".uno:NextRecord", I gave a try
with this patch:
diff --git a/extensions/source/propctrlr/pushbuttonnavigation.cxx
b/extensions/source/propctrlr/pushbuttonnavigation.cxx
index 3d1bf748c712..786ef8862eb6 100644
--- a/extensions/source/propctrlr/pushbuttonnavigation.cxx
+++ b/extensions/source/propctrlr/pushbuttonnavigation.cxx
@@ -43,7 +43,7 @@ namespace pcr
         {
             ".uno:FormController/moveToFirst",
             ".uno:FormController/moveToPrev",
-            ".uno:FormController/moveToNext",
+            ".uno:NextRecord",
             ".uno:FormController/moveToLast",
             ".uno:FormController/saveRecord",
             ".uno:FormController/undoRecord",
diff --git a/forms/source/inc/frm_strings.hxx
b/forms/source/inc/frm_strings.hxx
index 06d3f8cb148b..af69996206c5 100644
--- a/forms/source/inc/frm_strings.hxx
+++ b/forms/source/inc/frm_strings.hxx
@@ -274,7 +274,7 @@ namespace frm
     #define URL_FORM_RECORDCOUNT  ".uno:FormController/RecordCount"
     #define URL_RECORD_FIRST      ".uno:FormController/moveToFirst"
     #define URL_RECORD_PREV       ".uno:FormController/moveToPrev"
-    #define URL_RECORD_NEXT       ".uno:FormController/moveToNext"
+    #define URL_RECORD_NEXT       ".uno:NextRecord"
     #define URL_RECORD_LAST       ".uno:FormController/moveToLast"
     #define URL_RECORD_SAVE       ".uno:FormController/saveRecord"
     #define URL_RECORD_UNDO       ".uno:FormController/undoRecord"
diff --git a/svx/source/inc/fmurl.hxx b/svx/source/inc/fmurl.hxx
index a354eae59e84..bd6c9837e047 100644
--- a/svx/source/inc/fmurl.hxx
+++ b/svx/source/inc/fmurl.hxx
@@ -24,7 +24,7 @@
 #define FMURL_FORM_RECORDCOUNT             ".uno:FormController/RecordCount"
 #define FMURL_RECORD_MOVEFIRST             ".uno:FormController/moveToFirst"
 #define FMURL_RECORD_MOVEPREV              ".uno:FormController/moveToPrev"
-#define FMURL_RECORD_MOVENEXT              ".uno:FormController/moveToNext"
+#define FMURL_RECORD_MOVENEXT              ".uno:NextRecord"
 #define FMURL_RECORD_MOVELAST              ".uno:FormController/moveToLast"
 #define FMURL_RECORD_MOVETONEW             ".uno:FormController/moveToNew"
 #define FMURL_RECORD_UNDO                  ".uno:FormController/undoRecord"

Then I modified the form to use next record for the image control since it was
broken with the patch then it worked!

So do you think it's the right way or should we stick to urls like:
.uno:FormController/<action> ?
I mean, I'm not sure these uno/FormController work in other cases so even if
the each exiting forms will have to be modified, since it didn't work at first
place, I think it might be the right move.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201129/4b2a0ab4/attachment.htm>