[Libreoffice-bugs] [Bug 137241] Unable to backspace over some text (track changes)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=137241

--- Comment #2 from Telesto <telesto at surfxs.nl> ---
Created attachment 166137
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166137&action=edit
Bibisect log

Bisected to:
author  Michael Stahl <Michael.Stahl at cib.de>    2020-06-19 16:32:19 +0200
committer       Michael Stahl <michael.stahl at cib.de>    2020-06-19 20:50:58
+0200
commit  92dbbf840c1da7628bcdd9e8f67375efc2a2fa14 (patch)
tree    2dcb2e1be891b27cd5619478678d9b6eba3fe464
parent  461e9f2ad21046526c6644136f0abda91b0e4798 (diff)
tdf#127635 sw_redlinehide: put point at the end of deletion
SwWrtShell::Insert() is called with a selection, so it first calls
DeleteAndJoin() to get rid of the selection.

With redlining enabled, this leaves the cursor as it was before, so if
the point was at the start it still is at the start, so the following
Insert will insert at the start of the selection.

But then AutoCorrect wants to do things and it uses TextFrameIndex and
ViewToModelPos and gets a result at the end of the delete redline,
while the cursor remains at the start of the delete redline.

Avoid this by swapping the selection after DeleteAndJoin() (and also
DeleteRange() for consistency) so that insertion happens at end of
redline (swap "above" DoWithBreaks because it creates temporary PaMs).

(regression from sw_redlinehide)

https://cgit.freedesktop.org/libreoffice/core/commit/?id=92dbbf840c1da7628bcdd9e8f67375efc2a2fa14

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201006/9c84cbc1/attachment.htm>