[Libreoffice-bugs] [Bug 136294] Red wrong spelled lining needs a trigger to get activated (spell checker)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=136294

Telesto <telesto at surfxs.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glogow at fbihome.de

--- Comment #15 from Telesto <telesto at surfxs.nl> ---
@Jan-Marek
This is a kind flaw which make the spell checker look broken.. It will short
out itself after clicking somewhere, but it's discomforting. Huh.. why is the
word not underlined? So not 'critical' but more annoying.

You're being the timer expert. M. Stahl has enough on his plate already. And
code being kind of magic to me. So an attempt to get someone interested. 
Not saying you are available or must look into it ;-). However I would love
this to disappear as this not being nice from user experience perspective. Or
I'm personally attributing to much worth to it, however there are some
duplicates.

So question is, is there a different approach to M. Stahl is solution? Or is it
as simple as making key-press (say CTRL+Z or mouse click) trigger a next run.
Don't believe this, as I assume I would have been considered back then..


> Bisected to
> author	Michael Stahl <mstahl at redhat.com>	2015-09-09 10:30:04 +0200
> committer	Michael Stahl <mstahl at redhat.com>	2015-09-09 14:13:48 +0200
> commit	4c91e94e892943ef5e031d65f6f42864233cb4cd (patch)
> tree	c9f6e59cf2d776e028692ff19e58af57fea5deeb
> parent	f9f3e97ca867db59f2fc2e4fdb5583ed49cab49c (diff)
> tdf#92036: sw: fix idle spelling loop
> There is a sort of intentional infinite loop in the idle spell checking
> handler: while the user is typing a word, it should not be marked as
> invalid yet, in order not to annoy them with red underlines.
> 
> So the word where the cursor is positioned always remained dirty, unless
> you happen to have a grammar checker enabled, which clears the
> paragraph's dirty flag from a separate thread.
> 
> To avoid the infinite loop, add another spell checking state "PENDING"
> which is the same as dirty except that it should cancel the idle spell
> checking.
> 
> The idle spell checking will run again when the user does the next
> editing operation.  Notably this means if the user just moves the cursor
> out of the wrongly spelled word, it won't be underlined yet, but that
> appears a minor issue, and checking when the cursor leaves the word
> appears too hard to implement.
> 
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=4c91e94e892943ef5e031d65f6f42864233cb4cd

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201012/ccdb2779/attachment.htm>