[Libreoffice-bugs] [Bug 137525] New: Update ColumnValueSet drawing to use the Push/Pop API

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Fri Oct 16 10:21:30 UTC 2020


https://bugs.documentfoundation.org/show_bug.cgi?id=137525

            Bug ID: 137525
           Summary: Update ColumnValueSet drawing to use the Push/Pop API
           Product: LibreOffice
           Version: Inherited From OOo
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: trivial
          Priority: medium
         Component: Writer
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: glogow at fbihome.de

While fixing bug 136924, I found the code manually restores the line and fill
colors it changed in the ColumnValueSet::UserDraw function. There is a more
"modern" API (Push/Pop) in RenderContext using PushFlags to restore these more
automatically. So get rid of the manual backup of the colors and call the API
instead.

Code is in sw/source/ui/frmdlg/column.cxx

There are probably more places in the codebase, which could be converted, but I
don't see a way to identify them, so this is just a single easy hack.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201016/e6f90a2f/attachment-0001.htm>


More information about the Libreoffice-bugs mailing list