[Libreoffice-bugs] [Bug 137468] Severe performance degradation on a macOS with a 5K display

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=137468

--- Comment #20 from Luboš Luňák <l.lunak at collabora.com> ---
(In reply to Luboš Luňák from comment #18)
> I'm not familiar with the quartz VCL backend, but I doubt there's a simple
> patch for making it use Skia, the backend would need to get ported to use
> Skia APIs (or use pluggable implementations the same way Windows and 'gen'
> backends do).

To elaborate more on this, in case somebody would like to implement Skia
support for Mac:

The Skia support on Windows (and on Linux with the 'gen' VCL backend) works by
having the WinSalGraphics class forward all the graphic calls to
SalGraphicsImpl base class that actually performs them (see e.g.
WinSalGraphics::drawLine()). And Skia use is done by having
WinSkiaSalGraphicsImpl class be the actual class that performs the drawing. The
rest of the platform-specific code such as window handling is still done by
WinSalGraphics and other classes from the 'win' backend.

So Skia support on Mac would presumably require changing the 'quartz' VCL
backend to work similarly. I.e. make AquaSalGraphics forward drawing calls to
SalGraphicsImpl implementation, move the current drawing code to
AquaSalGraphicsImpl (or whatever it would be called), and then create
AquaSkiaSalGraphicsImpl, which would inherit from SkiaSalGraphicsImpl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201019/9e2f0d53/attachment.htm>