[Libreoffice-bugs] [Bug 99116] StartCenter’s hardcoded color scheme doesn’t work for high-contrast mode users

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=99116

--- Comment #16 from Jan-Marek Glogowski <glogow at fbihome.de> ---
(In reply to V Stuart Foote from comment #13)
> Created attachment 166270 [details]
> current 20201011 master against 7.1.0 - Win10 HC#1 highcontrast mode

This looks the same (AKA broken highcontrast) in the build before the patch was
merged. Feel free to revert that patch, if you make the setting optional. Just
start Writer on Windows, which looks even more broken in multiple ways, because
most backgrounds in the toolbars aren't dark. Also the menu text is green,
while it's white in notepad. There is simply much more to fix, but mapping the
right colors to LO's theming is generally not rocket science (but probably
guesswork, because of the huge amount of theming colors in LO, needed or not).

> We used to have the StartCenterBackgroundColor and StartCenterTextColor [1]
> implemented for consistent SC UI--i.e. "Branding". 
>
> But that was recently stripped out for bug 136555 [2] for "better" os/DE
> theming support, which of course doesn't work for Windows, and not sure if
> the macOS builds do better.

The patch was also a reaction to MacOS based changes, and that author was in
the loop. So I guess they are tested on MacOS too.

The start center now uses the colors from the theme for the button area, which
uses GetWorkspaceColor, which is supposed to use GetSysColor(COLOR_MENU), but
just if officecfg::Office::Common::Accessibility::AutoDetectSystemHC::get(),
for whatever reason, instead of always setting it from the theme.

FWIW you can still set the background image for some "branding" of the start
center.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201022/48ae15c1/attachment.htm>