[Libreoffice-bugs] [Bug 121553] Editing: Firebird: Table editor erroneously prompts to change CLOB field to a BLOB field during alter table

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121553

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |serval2412 at yahoo.fr

--- Comment #5 from Julien Nabet <serval2412 at yahoo.fr> ---
Lionel: I tried 2 ways to fix this:
1) In ODatabaseMetaData::getTypeInfo(), replace:
aRow[1] = new ORowSetValueDecorator(OUString("BLOB")); // BLOB, with subtype 1
by
aRow[1] = new ORowSetValueDecorator(OUString("CLOB")); // BLOB, with subtype 1
See 
https://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/firebird/DatabaseMetaData.cxx?r=1daeea3a#885

2) In firebird::ColumnTypeInfo::getColumnTypeName()
Replace:
         case DataType::CLOB:
            return "CLOB";
by
         case DataType::CLOB:
            return "BLOB";
See connectivity/source/drivers/firebird/Util.cxx (not present in Opengrok yet
since the patch is recent).

But considering http://www.firebirdfaq.org/faq48/, if we want to stick to
Firebird naming, I think 2) should be chosen.
Now I must recognize it's not easy to think the impacts of each way.

Any thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201029/91a22033/attachment.htm>