[Libreoffice-bugs] [Bug 134161] CPU at 100% after opening a particular spreadsheet

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=134161

--- Comment #4 from Aron Budea <baron at caesar.elte.hu> ---
I can already see that this difference is a problem:
https://opengrok.libreoffice.org/xref/core/sc/source/core/data/stlsheet.cxx?r=b225980d#284

if ( rNew == aFileStdName && aFileStdName !=
ScResId(STR_STYLENAME_STANDARD_CELL) )
    return false;
else if ( rNew == aFileStdName && aFileStdName !=
ScResId(STR_STYLENAME_STANDARD_PAGE) )
    return false;
else
    return SfxStyleSheet::SetName(rNew, bReindexNow);

========

If 'rNew == aFileStdName' is true, it'll either return false in the first
branch, or in the second, and never gets to the third, ie. this kind of
branching makes no sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201030/57cac899/attachment.htm>