[Libreoffice-bugs] [Bug 133630] CRASH: Chart: Changing properties in different objects

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=133630

Leyan <ouyang.leyan at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ouyang.leyan at hotmail.com

--- Comment #12 from Leyan <ouyang.leyan at hotmail.com> ---
(In reply to Michael Meeks from comment #7)
> Ah - I am interested of course =) but my fix was in fact a complete accident
> ;-) presumably it is a side-effect of lurking not actually destroying the
> sidebar panel widgets - but keeping them around: a vital optimization for
> mobile.
> 
> Is there a stack-trace ?

I got the same kind of crash, with slightly different repro steps. I tried to
understand what happened in the code, it seems that the ModifyListener of the
different panels sometimes (always?) stay active once created, then they try to
update the corresponding data, even if the currently selected object is not of
the correct type. This causes issues with axes especially: either an assert in
debug mode (complaining about the object type, the one in Comment 8) or an
exception otherwise.

I managed to avoid the crash I saw by adding a sanity check inside
ChartAxisPanel::updateData(), but what would be the correct way to solve this?
Just more checks on object types at each updateData? Or a way to remove
listeners without destroying the widgets?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200906/7704b2a4/attachment-0001.htm>