[Libreoffice-bugs] [Bug 104369] Provide a live preview of charts inside the chart wizard window (or make that dialog non modal ta avoid blocking the view)

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Tue Sep 8 19:03:43 UTC 2020


https://bugs.documentfoundation.org/show_bug.cgi?id=104369

--- Comment #5 from Jean-François Fortin Tam <nekohayo at gmail.com> ---
I had a "How Hard Can It Be?™ " moment where I thought "This might be a
one-liner fix to make it non-modal", and so I ran "git grep -i modal chart2/"
which gave me this:

    chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx: void SAL_CALL
CreationWizardUnoDlg::startExecuteModal(blah blah blah)
    chart2/source/controller/dialogs/res_ErrorBar.cxx:   
pWeldDialog->set_modal(!bEnable);
    chart2/source/controller/dialogs/tp_DataSource.cxx:   
pDlg->set_modal(!bEnable);
    chart2/source/controller/dialogs/tp_RangeChooser.cxx:       
pDlg->set_modal(!bEnable);
    chart2/source/controller/inc/dlg_CreationWizard_UNO.hxx:    virtual void
SAL_CALL startExecuteModal(blah blah blah)

    chart2/uiconfig/ui/3dviewdialog.ui:    <property
name="modal">True</property>
    chart2/uiconfig/ui/attributedialog.ui:    <property
name="modal">True</property>
    chart2/uiconfig/ui/chartdatadialog.ui:    <property
name="modal">True</property>
    chart2/uiconfig/ui/charttypedialog.ui:    <property
name="modal">True</property>
    chart2/uiconfig/ui/datarangedialog.ui:    <property
name="modal">True</property>
    chart2/uiconfig/ui/dlg_InsertErrorBars.ui:    <property
name="modal">True</property>
    chart2/uiconfig/ui/dlg_InsertLegend.ui:    <property
name="modal">True</property>
    chart2/uiconfig/ui/insertaxisdlg.ui:    <property
name="modal">True</property>
    chart2/uiconfig/ui/insertgriddlg.ui:    <property
name="modal">True</property>
    chart2/uiconfig/ui/inserttitledlg.ui:    <property
name="modal">True</property>
    chart2/uiconfig/ui/smoothlinesdlg.ui:    <property
name="modal">True</property>
    chart2/uiconfig/ui/steppedlinesdlg.ui:    <property
name="modal">True</property>

I thought the fix could simply be to remove (or comment out, on my Fedora
system's installed files in
/usr/lib64/libreoffice/share/config/soffice.cfg/modules/schart/ui/ ...) the
'<property name="modal">True</property>' lines for chartdatadialog.ui,
datarangedialog.ui, charttypedialog.ui, but it doesn't seem to actually make
them non-modal in practice... As if some part of the code overrides all of
that, maybe those "startExecuteModal" function calls? If so that's beyond my
simple tinkering ability, but I suspect it would still be fairly easy to solve
for an experienced LibreOffice contributor. I do think making all the "large
view-blocking dialogs that should not block the view because the chart preview
depends on that" non-modal is the easiest and most reasonable approach (bonus
points for setting the dialogs' position to avoid overlapping the chart by
default, ideally)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200908/6ce6ae5f/attachment.htm>


More information about the Libreoffice-bugs mailing list