[Libreoffice-bugs] [Bug 136598] New: Revalidate paragraph signatures only after find & replace operation is completed

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Wed Sep 9 10:12:45 UTC 2020


https://bugs.documentfoundation.org/show_bug.cgi?id=136598

            Bug ID: 136598
           Summary: Revalidate paragraph signatures only after find &
                    replace operation is completed
           Product: LibreOffice
           Version: 5.0.0.5 release
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Keywords: perf
          Severity: enhancement
          Priority: medium
         Component: Writer
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: ilmari.lauhakangas at libreoffice.org

Futher optimisation opportunity from bug 119286 comment 14

Quote:
"We repeatedly revalidate the paragraph signature. Since we're making changes
to individual words/letters, this is effectively O(n^2). A smarter thing to do
would be to only do this validation after the replace operation."

This "is tricky because it uses the UNO API to inspect the document, while the
rest of the code is using the internal raw API"

Perf can be tested like so:
1. Open attachment 144181
2. Disable the automatic spell checking if enabled
3. In the Search for field put "." (a single period)
4. In the Replace with field put "x"
5. Make sure Whole words only is unchecked
6. Click Other Options to expand the dialog, and make sure Regular expressions
is checked
7. Click Replace All

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200909/bd82a924/attachment.htm>


More information about the Libreoffice-bugs mailing list