[Libreoffice-bugs] [Bug 134785] FILEOPEN PPTX: text box and line not shown in presentation mode

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=134785

--- Comment #8 from Michael Meeks <michael.meeks at collabora.com> ---
Ah - a wonderful example of a commit accidentally fixing one bug, but creating
a slew of other regressions. From what I recall of the subtle side-effects of
this one item cache:

+    // We get dozens of back-to-back calls for the same shape
+    if( pCustomShape == g_pLastCacheShape )
+        return xCustomShapeEngine;

That the previous author wrote:

-    Reference< XCustomShapeEngine > xCustomShapeEngine( GetCustomShapeEngine(
this ) ); // a candidate for being cached

;-) gave a really nice performance win for a while, and seemed clean - but ...
I guess something there is biting us in the coupling.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200912/1f845dab/attachment.htm>