[Libreoffice-bugs] [Bug 136555] StartCenter is inconsistent with dark theme(s)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=136555

Jan-Marek Glogowski <glogow at fbihome.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thorsten.wagner.4 at gmail.com
           Keywords|bibisectRequest             |
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=12
                   |                            |5532,
                   |                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=13
                   |                            |4708,
                   |                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=90
                   |                            |452

--- Comment #5 from Jan-Marek Glogowski <glogow at fbihome.de> ---
Broken since commit:

commit 8d11b953c0a69f4f5eb5ca42dec3812a62d0cd0f
Author: Thorsten Wagner <thorsten.wagner.4 at gmail.com>
Date:   Sun Feb 23 21:11:05 2020 +0100

    tdf#125532: White text on default/action buttons and selected tabs on macOS

and IMHO made worse by

commit 84b2849512bdb19597739d9515dd55e2d3ba9504
Author: Thorsten Wagner <thorsten.wagner.4 at gmail.com>
Date:   Tue Jul 28 00:36:07 2020 +0200

    tdf#134708 Text coloring of buttons within forms amended

which will hit users in 7.0.2 and master.

But honestly I'm not sure about a good fix.

If you have any "advanced" theming of buttons on your platform, it might
include a different background of the button in various states.

So maybe it's sensible to ignore the foreground color, if you don't set a
custom background. OTOH I really doubt this is a sensible and understandable
constraint for any form designer in Base. Maybe Base shouldn't use any theming
to begin with. Anyway, commit 84b2849512bdb19597739d9515dd55e2d3ba9504 adds a
new constraint.

Fact is the current state is broken and it'll be more broken in 7.0.2, when the
2nd patch hits the users.

As a fix for the start center, I simply dropped button theming:
https://gerrit.libreoffice.org/c/core/+/103041

That was decided and introduced in bug 90452.

Or we want a platform setting, so the start center button theming can be
ignored by some platforms, like kf5?

Also notice, that the "Create" label has a different / correct font color.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200919/b9e06ac4/attachment.htm>