[Libreoffice-bugs] [Bug 137171] New: Please un-hide "show icons in menus" and "show shortcuts in context menus" options for GTK3

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=137171

            Bug ID: 137171
           Summary: Please un-hide "show icons in menus" and "show
                    shortcuts in context menus" options for GTK3
           Product: LibreOffice
           Version: 7.0.1.2 release
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: UI
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: ming.v.hua at qq.com
                CC: caolanm at redhat.com

According to bug 123265 comment 16 and bug 123265 comment 20, the "Icons in
menus" and "Shortcuts in context menus" options in Tools > Options >
LibreOffice > View stopped working in GTK3 VCL, and as a consequence these two
options were hidden by commit:

https://git.libreoffice.org/core/commit/0d6a64c218791156e050c2050b8070d40fdacf97

Resolves: tdf#123265 hide show-icons under gtk3

However, according to bug 123265 comment 41, the options stopped working
because the fix for bug 126830 got lost during the GTK2 cleanup, and commit:

https://git.libreoffice.org/core/commit/9e129e8557370207f784cba0f40643044ead88be

Restore the fix for tdf#126830

has restored the fix, and these two options should work in GTK3 VCL now.

In light of these, I don't see the reason to hide these options anymore, and
they should be shown to GTK3 users who don't/can't set system-wide setting for
all applications about menu icons.  In other words,
0d6a64c218791156e050c2050b8070d40fdacf97 probably should be reverted.

Caolán, as you were the author of the original commit that hid the options, I
hope you don't mind me adding your to CC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200930/c26d4172/attachment.htm>