[Libreoffice-bugs] [Bug 141499] New: Crash inserting hyperlink (fairly often) and cursor not starting in URL field

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=141499

            Bug ID: 141499
           Summary: Crash inserting hyperlink (fairly often) and cursor
                    not starting in URL field
           Product: LibreOffice
           Version: 7.2.0.0.alpha0+ Master
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: Writer
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: jluth at mail.com

Created attachment 170967
  --> https://bugs.documentfoundation.org/attachment.cgi?id=170967&action=edit
130056_hyperlink.odt

Both the crashing and the cursor not starting in the URL field when inserting a
hyperlink started at the same 7.2 commit.

commit 9ffd28c32a301141a26e41ddd0cf485a562c83bb
Author: Caolán McNamara on Fri Mar 5 16:13:19 2021 +0000
    use container_focus_changed instead of toplevel_focus_changed

    seeing as its the same thing, but available one level of
    inheritance down

The crashing part seems to be here (and avoided by the indicated diff marks):
void SfxModelessDialogController::Activate()
{
    if (!m_xImpl)
        return;
+    if (!m_xImpl->pMgr)
+       return;

    m_pBindings->SetActiveFrame(m_xImpl->pMgr->GetFrame());

Steps to (fairly reliably) reproduce
1.) open 130056_hyperlink.odt.
2.) highlight any word ("Internet") and press Ctrl-K (insert hyperlink). 
Notice that the cursor is NOT waiting for you to start typing. It was nicer
before the identified commit.
3.) type a URL ("junk") and hit enter.
Frequently at this point LO will crash and start program recovery.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210405/40cd79b9/attachment.htm>