[Libreoffice-bugs] [Bug 123152] [Regression] USB dialog pops up every time I do something with usb, please don't

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Wed Apr 7 09:01:04 UTC 2021


https://bugs.documentfoundation.org/show_bug.cgi?id=123152

Michael Weghorn <m.weghorn at posteo.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.weghorn at posteo.de
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Michael Weghorn <m.weghorn at posteo.de> ---
This should no longer be a problem, since custom USB device handling has been
removed in this commit:

commit a23bd42e9b2f6401c710ac95afcc3aa8f360d65c
Author: Michael Weghorn <m.weghorn at posteo.de>
Date:   Tue Apr 6 14:26:06 2021 +0200

    android: Drop custom file abstraction + UI

    Android Viewer had its own file abstraction layer.

    From the (now deleted) IFile.java:

    > An abstraction of the File class, intended to be implemented by different
    > Document Providers.
    >
    > It represents a file or a directory in the context of a certain Document
    > Provider. It wraps the file-related operations and provides access to the
    > final document as a local File, downloading it if necessary.

    However, Android already provides such an abstraction by
    what is called "documents provider" there as well, s. [1].
    Android Viewer has previously been adapted to
    support and make use of that.
    Therefore, drop the custom implementation to avoid
    duplication and having to reimplement functionality
    already provided otherwise.

    Also, drop the custom UI elements to display and
    select files implemented on top of the custom
    file abstraction. Support for using the system file
    picker (via the corresponding Intents) has been added
    earlier and is now the only available option to open
    files from within the app.

    [1]
https://developer.android.com/training/data-storage/shared/documents-files

    Change-Id: Ide529e836a32fd7e880e5a72d971af9f9c7e74bf
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113667
    Tested-by: Jenkins
    Reviewed-by: Michael Weghorn <m.weghorn at posteo.de>

Please add more details in case there is still any issue with a daily build
from tomorrow or newer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210407/082dbde9/attachment-0001.htm>


More information about the Libreoffice-bugs mailing list