[Libreoffice-bugs] [Bug 141908] New: CppUnittests: replace usage of sal_Int32 with colors

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Mon Apr 26 10:05:38 UTC 2021


https://bugs.documentfoundation.org/show_bug.cgi?id=141908

            Bug ID: 141908
           Summary: CppUnittests: replace usage of sal_Int32 with colors
           Product: LibreOffice
           Version: 7.2.0.0.alpha0+ Master
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: LibreOffice
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: xiscofauli at libreoffice.org

Some CppUnittests use 'sal_Int32' instead of 'Color' to deal with color
properties. If the fail, the output from the assert looks like

- Expected: 14729932
- Actual  : 14729933

while if 'Color' is used, the output is

- Expected: Color: R:224 G:194 B:204 A:0
- Actual  : Color: R:224 G:194 B:205 A:0

which is more human readable.
This task is about looking for unittests where sal_Int32 is used and replaced
them with Color. In Writer, the unittests are in sw/qa, in Calc in sc/qa and in
Impress in sd/qa

Example:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=a7d862560e273442891432a88dff9a320c80575a

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210426/f1f9b318/attachment-0001.htm>


More information about the Libreoffice-bugs mailing list