[Libreoffice-bugs] [Bug 143759] Inaccurate results when searching for empty cells with regex ^$

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=143759

stragu <stephane.guillou at member.fsf.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|6.2.5.2 release             |5.2.0.4 release

--- Comment #4 from stragu <stephane.guillou at member.fsf.org> ---
Thanks Eike.
About the range outside of the data area: that makes sense that it is not
currently searched currently.
It is even commented about in the code:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=69ac605191860aceee09f1147a5234222d1b3300
But wondering if ScTable::SearchAndReplaceEmptyCells could be improved by
adding an extra step:
1. remove the range outside the data area before searching (current behaviour);
2. search inside the data area (current behaviour);
3. add the outside selection back into returned selection (added step).
That wouldn't add unnecessary overhead, but would result in a more expected
behaviour, in my opinion.

In any case, the most important issue is obviously the second part about
returning selected cells that weren't originally part of the selection.

Reproduced in 5.2.0 as well, so assuming the behaviour started with the commit
linked above.

Version: 5.2.0.0.alpha1
Build ID: 902b28a39528b6c92602e9b521a1d0861be1caf9
CPU Threads: 4; OS Version: Linux 5.4; UI Render: default; 
Locale: en-AU (en_AU.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210807/dabc54e6/attachment.htm>