[Libreoffice-bugs] [Bug 143577] Crash on image delete with "Show outline-folding buttons"

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=143577

Jim Raykowski <raykowj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|libreoffice-bugs at lists.free |raykowj at gmail.com
                   |desktop.org                 |

--- Comment #10 from Jim Raykowski <raykowj at gmail.com> ---
(In reply to Julien Nabet from comment #9)
> Jim: I noticed 2 things
> 1) about the crash itself, it crashes because of this line:
> 207 aIdx.GetNode().GetTextNode()->GetAttrOutlineContentVisible(bVisible);
> In the case of the bugtracker aIdx.GetNode() isn't a text node, it's a graph
> node.
> 

right, need to make sure the node is actually a text node. 

> 2) I don't understand the adding of returns in
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=6b09276d157abada74e1a4989700139167207778
> I mean, in case we enter the return instructions, we never execute the
> instructions after the switch:
> 
> 273     rReq.Done();
> 274 
> 275     //#i42732# - notify the edit window that from now on we do not use
> the input language
> 276     rTmpEditWin.SetUseInputLanguage( false );
> 
> Is it expected?

right again, returns should be breaks

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210809/52c13813/attachment.htm>