[Libreoffice-bugs] [Bug 143268] Slow response in document with many tables

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=143268

Buovjaga <ilmari.lauhakangas at libreoffice.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |raykowj at gmail.com

--- Comment #31 from Buovjaga <ilmari.lauhakangas at libreoffice.org> ---
(In reply to David from comment #30)
> I did some more testing.  The regression is that with 7.x, the Table tree
> automatically expands when there are tables in the document.  In 6.x, the
> Table tree remains collapsed after a document is opened, even when typing in
> a table, until the tree is manually expanded.  When the tree in 6.x is
> expanded, then it has the same delayed response as 7.x, even if the tree is
> subsequently collapsed.
> 
> The delay is being caused by the SwTable::GetInfo subroutine in
> sw/source/core/table/swtable.cxx.
> 
> Adding 'return false;' to the beginning of 'case RES_AUTOFMT_DOCNODE:' case
> statement corrects the slow response time.  In fact, it is not obvious to me
> what negative ramifications there are to replacing the commands in this case
> statement with 'return false;'.  As far as I can tell, everything still
> seems to function properly and with a normal response time.
> 
> But is it necessary to call this subroutine on every key press?  It would
> seem to me that it should only be called if a table is inserted or removed
> or has a name change.  And if the commands in the specified case statement
> do need to be executed, is there a more efficient way of programming them?
> 
> Or is the easiest fix for this issue simply to replace the commands executed
> by this case statement with 'return false;'?

Thanks a lot for investigating! For me, the Table tree expands when I move the
focus into a table. However, it does remember the expanded state between
sessions.

Tracking the focus was added in 7.1 with
https://git.libreoffice.org/core/commit/dda71436b8594fb0669b3ac06c02a3997a0674be
tdf#95378 Writer Navigator document content tracking

Let's ask Jim what he thinks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210830/be06cead/attachment.htm>