[Libreoffice-bugs] [Bug 138484] OPTIONS DIALOG: Settings for printing comments have no effects

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=138484

--- Comment #4 from Michael Weghorn <m.weghorn at posteo.de> ---
(In reply to Buovjaga from comment #3)
> Bibisected with linux-64-7.0 to range
> https://cgit.freedesktop.org/libreoffice/core/log/
> ?qt=range&q=807e075a6184f7afc01a127abe77391238ab4163...
> 25cca30ef5f27b0a20ea7da79d0ddea66dc98d93
> out of which this seems relevant:
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=d23c52cbf7e48130fec1e48bf726c563035a3497
> tdf#47583 sw: Don't mix doc print settings into option dialog
> 
> Adding Cc: to Michael Weghorn

Indeed, that's the commit that changes the behavior. The change was intended;
quoting from my own commit message:

> tdf#47583 sw: Don't mix doc print settings into option dialog
> 
> Show and manage the default Writer print options in the "Tools" ->
> "Options" -> "LibreOfficeDev Writer" -> "Print" dialog and don't
> mix in the document-specific values of the currently opened
> document, as this is rather confusing as described in tdf#47583.
> 
> There is a separate dialog to manage the settings for the currently
> opened document available via "File" -> "Printer Settings" -> "Options".
> 
> At a quick glance, this also matches the behaviour for Calc, which
> doesn't mix in the current doc's settings either.
> 
> This handles the case for the Writer-specific print options.
> For a more general approach on whether and how document-specific
> options should be handled in the "Tools" -> "Options" dialog at all,
> there are already tdf#43786 ("Intransparent Use of Options")  and
> tdf#105751 ("Separate document saved options from global options in
> Options dialog").
> 
> Side note: The previous implementation also wasn't synchronizing the
> settings both ways. Changes made in the "File" -> "Printer Settings" ->
> "Options" dialog did show up in the "Tools" -> "Options" ->
> "LibreOfficeDev Writer" -> "Print" dialog at once, but not the other
> way around.

The setting in "Tools" -> "Options" defines the default value to use for *new*
documents, while the one in "File" -> "Printer Settings" handles that of the
current document, i.e. changing the one in "Tools" -> "Options" will only take
effect when creating a new document.

See tdf#47583 for more background which describes how the previous behavior was
even more confusing.

Inserting a corresponding heading/tag as suggested in the proposal from
tdf#47583 comment 0 would probably help to make this clearer:

> Proposal in order to make the behaviour more transparent:
> Insert a heading to the option category 'LibreOffice Writer > Print': "Initial Print Options of new Documents". And of course print options of current documents should not longer displayed in the general options dialog.

IMHO, if changed, that should be handled consistently with other places as
well, s. my tdf#47583 comment 14:

> I'm looking into the second aspect mentioned here (not displaying document-specific settings in "Tools" -> "Options"; Calc also doesn't do this).
> I suggest to then handle the "remainder" (i.e. proper labels/headings) in bug 118262, where this is also already mentioned.

tdf#118262 mentions more areas where the current handling of
general/file-specific options is not ideal.


Given that, I'd suggest that this is not a regression but a "Works For Me" (but
I agree that it may be confusing, s. above comments with further details and
existing ideas/tickets to improve this further).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210225/5ac32fae/attachment.htm>