[Libreoffice-bugs] [Bug 139503] No playing item in presentation mode (GDI)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=139503

--- Comment #2 from Telesto <telesto at surfxs.nl> ---
Created attachment 168779
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168779&action=edit
Bibisect log

Bisected to

author  Miklos Vajna <vmiklos at collabora.com>    2019-04-17 11:38:47 +0200
committer       Luboš Luňák <l.lunak at collabora.com>     2019-04-23 10:34:23
+0200
commit  5c5eab3522368d6baa7ab6ef1b6c9f5eaaab4fad (patch)
tree    64d3d77a6ffcbadd0a03cdaaeeef67912f61c8ed
parent  9a5e5c581eaf86ce0bbf293da40ba18c72fba1bd (diff)
tdf#124756 slideshow: avoid mbPaintDisabled for media windows
Commit 3e0092031b73bad107e3122d5d4be2f5bd487744 (tdf#112318 sd opengl:
fix lack of initial animation, 2019-04-05) enabled processing of idle
events between two updates of the slideshow to help OpenGL, which
uncovered a problem with media shapes.

On one hand,
slideshow::internal::ViewMediaShape::implInitializePlayerWindow() calls
EnablePaint(false) on the media window. OTOH,
vcl::Window::ImplCallPaint() handles mbPaintDisabled by invalidating the
relevant area of the window, which causes a paint<->invalidate loop.

Fix the problem by nominally still enabling paints on the media window:
nothing will change in practice (since the actual media overlay will be
on top of it), but this way the loop goes away.

mbPaintDisabled is handled like this since the initial import, the media
window flag was added much later, so it makes more sense to adapt the
later.

(cherry picked from commit d7f4f5650dd2c7fe1ccec50efd806e695b8bc18a)

Conflicts:
        slideshow/source/engine/shapes/viewmediashape.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210108/956dc51b/attachment.htm>