[Libreoffice-bugs] [Bug 139612] Option "Search criteria = and <> must apply to whole cells" doesn't affect to calculation as must.

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=139612

--- Comment #9 from Michael Meeks <michael.meeks at collabora.com> ---
Very little time to look at this. Looks like I created a unit test sheet for
this behavior, as such I imagine that when I created it we spent a chunk of
time analyzing what the right behavior is - particularly as regards
interoperability.

This code is at/near the center of many inner-loops and is intensely
performance critical:

commit afa91e423c2073cec281477f2154291c6d4f739d
Author: Dennis Francis <dennis.francis at collabora.co.uk>
Date:   Sat Apr 7 17:13:42 2018 +0530

    avoid SharedString copy assignment

commit 76bc1a81d089d9f66639c118c4063d87e4422684
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Thu Apr 5 16:15:32 2018 +0100

    tdf#115490 - avoid transliteration by using SharedString.

    Do this only for case insensitive matching for now; optimizing vlookup
    nicely - for me saves 35% of the compute time for 10k rows.

commit 009a326d78fb62a80f9631844af324d0294710b6
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Thu Apr 5 14:01:05 2018 +0100

    query entry - preparatory pure re-factor.

    No need to check lengths for ENDS_WITH - we get the right offsets
    to start with before indexOf, and separate nStrPos for later.


All of these are related. Carefully using the SharedString to do the
comparisons was a huge win where we can do that for case-insensitive
comparison.

What is the correct behavior: I'd look at interoperability first, common sense
next, and then the ODF spec. Someone needs to do that analysis though I'm
afraid I don't have time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210115/57bb8ceb/attachment.htm>