[Libreoffice-bugs] [Bug 136783] FILEOPEN: PPTX: Error reading file importing file with table

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Sat Jan 16 13:50:28 UTC 2021


https://bugs.documentfoundation.org/show_bug.cgi?id=136783

Justin L <jluth at mail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jluth at mail.com
           Assignee|libreoffice-bugs at lists.free |jluth at mail.com
                   |desktop.org                 |

--- Comment #3 from Justin L <jluth at mail.com> ---
simple solution is
- sal_Int32 nColumnSize = mvTableGrid.size();
+ sal_Int32 nColumnSize = std::min(tableRow.getTableCells().size(),
mvTableGrid.size());

However, my guess is that using mvTableGrid.size() is wrong.

I wanted to make a minimized test, but round-tripping this file in Word 2010
"fixes" the problem. (I see that is also noted in bug 115209 where they also
attempted a minimized file with attachment 153755.)

So then should we also mark this as "NOTOURBUG"? I assume this comes from slide
6 since I get debug output with tableproperties.cxx:149: ::pushToPropSet
rows[6] columns[1] grid[3]

However, since a bandaid fix is simple, I'll propose
http://gerrit.libreoffice.org/c/core/+/109438 and suggest that bug 133015
probably needs to be revisited and get a better fix than using grid size.

Since our unique document's size is very large, I'm not including a unit test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210116/4e21c100/attachment-0001.htm>


More information about the Libreoffice-bugs mailing list