[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robert at familiegrosskopf.de

--- Comment #9 from Julien Nabet <serval2412 at yahoo.fr> ---
(In reply to Caolán McNamara from comment #7)
> The "waiting state" is set in dbaccess/source/ui/app/AppControllerGen.cxx in
> OApplicationController::openDialog the ctor of the a WO weld::WaitObject and
> persists until its dtor.
I understand why there's this behavior and where it's located but I don't
understand what's the purpose of this "waiting state", just showing it's modal?
If yes why here and not on other modal dialogs?


> This is currently meant to be a modal dialog and it should have it modal bit
> set (https://gerrit.libreoffice.org/c/core/+/109540 to do that). In
> contemporary code if we wanted it to be a modeless dialog we'd unset its
> modal bit and instead of call Dialog::run we'd have to call runAsync instead.
With the last patch, the behavior is indeed now the same between gtk3, gen and
kf5.

Now should it be modal or not?
Personally, I don't have strong opinion here.

Robert/Alex: as expert Base users, any thoughts here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210118/37cf4139/attachment.htm>