[Libreoffice-bugs] [Bug 143293] New: slideshow_info is only ever sent once, even if presentation is switched

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=143293

            Bug ID: 143293
           Summary: slideshow_info is only ever sent once, even if
                    presentation is switched
           Product: Impress Remote
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: General
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: andrzej at ahunt.org

Description:
slideshow_info (containing the slideshow title) is currently sent only once -
when we first connect the remote client. That seems wrong - surely the user
could switch to a different presentation later on:
https://opengrok.libreoffice.org/xref/core/sd/source/ui/remotecontrol/Communicator.cxx?r=c7c6f0af#85-88

I noticed this when reviewing a crash-fix - it turns out that we
unconditionally try to read a title even if there's no presentation available -
which is being fixed in:
https://gerrit.libreoffice.org/c/core/+/102902

That fix will stop us from trying to send a title if there's no open
presentation - as a followup I'd like to play around with moving slideshow_info
to the same place that we send slideshow_started, i.e. here:
https://opengrok.libreoffice.org/xref/core/sd/source/ui/remotecontrol/Listener.cxx?r=5cfac9be#45-47

This seems to have existed since 8 years ago in:
https://git.libreoffice.org/core/+/b042a78d9847753d95560749dab2159d9cfbd7ae%5E%21/#F14

Steps to Reproduce:
Pure speculation (but I'll update this once I get round to working on the bug):
1. Open a presentation.
2. Connect the remote.
3. Open a different presentation, and start presenting.

Actual Results:
Pure speculation: the title of presentation 1 is shown.

Expected Results:
The title of presentation 2 is shown.


Reproducible: Always


User Profile Reset: No



Additional Info:
/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210710/1cbffd45/attachment.htm>