[Libreoffice-bugs] [Bug 143493] kf5: Typing apostrophe no longer works (at least with German keyboard layout)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=143493

Michael Weghorn <m.weghorn at posteo.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glogow at fbihome.de,
                   |                            |m.weghorn at posteo.de
           Keywords|                            |bibisected, bisected,
                   |                            |regression

--- Comment #1 from Michael Weghorn <m.weghorn at posteo.de> ---
This is a regression from

commit 862fdb98ca271b60a831cd5420fd16d5f9c1c747
Author: Jan-Marek Glogowski <glogow at fbihome.de>
Date:   Mon Jul 19 15:17:53 2021 +0200

    tdf#143298 Qt5 send SalEvent::KeyModChange events

    I originally omitted this in the Qt implementation, as I couldn't
    find any non-working use case.

    The implementation got a bit hacky, because Qt doesn't have a non-
    native way to identify different L/R modifier keys, so we must
    process the X11/xkb keycode ourself, which obviously won't work on
    Wayland... but most times this is not relevant, so the default
    modifier notification may be good enough.

    P.S. it's basically the same code then X11 and Gtk...

    Change-Id: I37fbfde4a33a966b6017f3e0c280e2c7ea91e4db
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119235
    Tested-by: Jenkins
    Reviewed-by: Michael Weghorn <m.weghorn at posteo.de>
    Reviewed-by: Jan-Marek Glogowski <glogow at fbihome.de>

and works again after locally reverting this commit

LO version I used for testing:

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 7be0f62de07aa3a046f0996eeb673d9a4d7c9672
CPU threads: 12; OS: Linux 5.10; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded

Adding CC: to Jan-Marek Glogowski

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210722/a00b0e7f/attachment-0001.htm>