[Libreoffice-bugs] [Bug 143526] New: Korean NumberFormats are missing on the Code

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=143526

            Bug ID: 143526
           Summary: Korean NumberFormats are missing on the Code
           Product: LibreOffice
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: LibreOffice
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: sungdh86 at gmail.com

Description:
I read the one of LibreOffice mailing lists.
What is the best fit for hindiVowels import? CHARS_PERSIAN or CHARS_NEPALI
https://lists.freedesktop.org/archives/libreoffice/2021-June/087533.html

I'm curious about Numbering Format for Korean on LibreOffice. 
I read the source code, "sw/source/filter/ww8/docxattributeoutput.cxx"
https://docs.libreoffice.org/sw/html/docxattributeoutput_8cxx_source.html 
https://git.libreoffice.org/core/+/refs/heads/master/sw/source/filter/ww8/docxattributeoutput.cxx


And I compare with "sw/source/filter/ww8/ww8atr.cxx" and Microsoft's OOXML
manual
https://docs.microsoft.com/en-us/openspecs/office_standards/ms-oe376/a5deef83-bb01-410f-bde0-9c35abe4ca52
[MS-DOCX]: Word Extensions to the Office Open XML (.docx) File Format
https://docs.microsoft.com/en-us/openspecs/office_standards/ms-docx/b839fe1f-e1ca-4fa6-8c26-5954d0abbccd
https://interoperability.blob.core.windows.net/files/MS-DOCX/%5bMS-DOCX%5d.pdf


that documents are showed "The mapped numbering format values table."


At the
code[https://git.libreoffice.org/core/+/refs/heads/master/sw/source/filter/ww8/docxattributeoutput.cxx],
Some Korean Numbering features are wrong and missing. 

I found the ST_NumberFormat on the document "[MS-OE376]: Office Implementation
Information for ECMA-376 Standards Support"
https://docs.microsoft.com/en-us/openspecs/office_standards/ms-oe376/a5deef83-bb01-410f-bde0-9c35abe4ca52
2.1.350 Part 4 Section 2.13.5.30, numberingChange (Previous Paragraph Numbering
Properties)
nfc Value | ST_NumberFormat enumeration equivalent 
24 | ganada
25 | chosung
41 | koreanDigital
42 | koreanCounting
43 | koreanLegal
44 | koreanDigital2

Follow values are Korean Numbering reserved values.

Also, This document "[MS-DOCX]: Word Extensions to the Office Open XML (.docx)
File Format" shows example of not only Korean Numbering also others Numbering
examples. 
https://docs.microsoft.com/en-us/openspecs/office_standards/ms-docx/b839fe1f-e1ca-4fa6-8c26-5954d0abbccd
2.4 numFmt Extensions
https://docs.microsoft.com/en-us/openspecs/office_standards/ms-docx/a1bb5809-e361-4e49-8e16-7f1a67da4121

String Attribute | value
U+3131, U+3134, U+3137, ... | chosung
U+AC00, U+B098, U+B2E4, ... | ganada
U+C77C, U+C774, U+C0BC, ... koreanCounting
U+C77C, U+C77CU+C601, U+C77CU+C601U+C601, ... | koreanDigital
U+4E00, U+4E00U+96F6, U+4E00U+96F6U+96F6, ... | koreanDigital2
U+D558U+B098, U+B458, U+C14B, ...  | koreanLegal


I found some missing reserved Korean Numbering features on LibreOffice.
Examples are "KoreanCounting", "KoreanDigital2"
https://git.libreoffice.org/core/+/refs/heads/master/sw/source/filter/ww8/docxattributeoutput.cxx

Also, Some Numbering feature is wrong for "KoreanDigital" and "KoreanLegal"
(Fortunately, "chosung" and "ganada" is correct and works good.)

So, I'll register the Some Korean Numbering reserves are wrong and missing. 

koreanDigital doesn't reserved style::NumberingType::NUMBER_HANGUL_KO.
Also, koreanLegal doesn't reserved style::NumberingType::NUMBER_UPPER_KO.
Example) 
"koreanDigital" add new reserved words "일, 일영, 일영영, etc"
"koreanCounting" is mapping style::NumberingType::NUMBER_HANGUL_KO.
"koreanLegal" is new reserved words "하나, 둘, 셋, 넷, 다섯, 여섯, 일곱, 여덟, 아홉, 열"
"koreanDigital" is new reserved works "一, 一零, 一零零, etc"

Steps to Reproduce:
1. Change the MS word's Numbering feature "koreanLegal"
2. add numbering titles


Actual Results:
일.
이.
삼.
사.
오.
육.
칠.
팔.
구.
십.
십일.
십이.


Expected Results:
하나.
둘.
셋.
넷.
다섯.
여섯.
일곱.
여덟.
아홉.
열.
열하나.
열둘.


Reproducible: Always


User Profile Reset: No



Additional Info:
I think, These features can only modified and checked for Korean.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210724/1015617f/attachment-0001.htm>