[Libreoffice-bugs] [Bug 98404] UX - While objects on a slide are being edited, notably text boxes, the new slide sorter Ctrl+Shift shortcut combinations (see bug 91909) incorrectly receive focus and move the slide

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=98404

--- Comment #25 from Bayram Çiçek <mail at bayramcicek.com.tr> ---
What I found so far:

-> Code pointers:

- for edit mode in ./sd/source/ui/func/futext.cxx:1034:
https://opengrok.libreoffice.org/xref/core/sd/source/ui/func/futext.cxx?r=9090dc1f#1034
- (found this with debugging) SID_MOVE_PAGE_UP (LAST/DOWN/FIRST) state methods
calls in:
https://opengrok.libreoffice.org/xref/core/sfx2/source/control/shell.cxx?r=a3d89265#492
- ExecMethod / StateMethod:
https://opengrok.libreoffice.org/xref/core/sd/sdi/SlideSorterController.sdi?r=951b243f#311
- Slide functions:
https://opengrok.libreoffice.org/xref/core/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx?r=9090dc1f#761
- https://opengrok.libreoffice.org/xref/core/sd/sdi/sdraw.sdi?r=951b243f#4654

-> In FuText:SetInEditMode, We should disable the global slide sorting
shortcuts by something like:

    SfxItemSet aSet(mpViewShell->GetPool());
    aSet.DisableItem(SID_MOVE_PAGE_DOWN);  // and other SIDs: (LAST/UP/FIRST)
or:
    SfxItemSet& rSet = mpView->GetStyleSheet()->GetItemSet();
    rSet.DisableItem(SID_MOVE_PAGE_DOWN);
or:
    SfxItemSet aSet(mpViewShell->GetPool(), svl::Items<EE_PARA_LRSPACE,
EE_PARA_LRSPACE>{} );
    aSet.DisableItem(SID_MOVE_PAGE_DOWN);
or:
    auto pSet = std::make_unique<SfxItemSet>( mpViewShell->GetPool());
    pSet->DisableItem(SID_MOVE_PAGE_DOWN);
or:
    SfxItemSet aSet(mpViewShell->GetDoc()->GetPool());
    aSet.DisableItem(SID_SLIDE_SORTER_MODE);


... but None of them are worked, and I don't know if there is another way to
make SIDs disable while in edit mode. Working on this bug for ~8 days but still
found no way to disable slide sorting shortcuts. Maybe, will look at it later.

---

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 4668e7e7a6322cfda854ab07eabd4322c86de980
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210620/850630ca/attachment-0001.htm>