[Libreoffice-bugs] [Bug 143108] PolyLine appearing/disappearing depending on zoom-level with Skia and anti-aliasing disabled

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Tue Jun 29 06:53:09 UTC 2021


https://bugs.documentfoundation.org/show_bug.cgi?id=143108

--- Comment #4 from Telesto <telesto at surfxs.nl> ---
Created attachment 173262
  --> https://bugs.documentfoundation.org/attachment.cgi?id=173262&action=edit
Bibisect log

Bisected to:
author  Luboš Luňák <l.lunak at collabora.com>     2020-09-25 13:30:11 +0200
committer       Luboš Luňák <l.lunak at collabora.com>     2020-09-29 09:54:42
+0200
commit  4deadc3c78949c18bb886eb1f66caa8f3cd7a2df (patch)
tree    c6c17519268c9adaf382f2dd07f71787e2d8cff5
parent  cd85546a2fbdade42f80fd3b6bd650791db9f32d (diff)
disentangle AA and B2D use in VCL drawing
A number of powerful functions using B2D polygons such as
OutputDevice::DrawPolyLineDirect() were used only if AA was enabled.
So e.g. dashing for an AA-ed polyline could be drawn directly
using the function, but with AA disabled had to be done manually
by a number of polygon operations. Which doesn't make much sense,
surely these powerful functions can also draw without AA if set so
(and indeed that's mostly the case). And DrawPolyLineDirect() even
had a flag to bypass the check.
So simply try to use B2D-based drawing whenever possible, AA or not.
The previous commit had already changed the naming of the AA option
to not include B2D in the name.

This seems to come from https://bz.apache.org/ooo/show_bug.cgi?id=88795,
which doesn't explain why AA only. There are other bugreports such as
https://bz.apache.org/ooo/show_bug.cgi?id=101491 and
https://bz.apache.org/ooo/show_bug.cgi?id=98289 that are related, but
there I cannot see any difference with this patch. And all unit tests
pass.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4deadc3c78949c18bb886eb1f66caa8f3cd7a2df

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210629/bf88cbdb/attachment.htm>


More information about the Libreoffice-bugs mailing list