[Libreoffice-bugs] [Bug 108518] FILEOPEN: DOC file list numbers incorrectly italicized

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=108518

--- Comment #13 from Justin L <jluth at mail.com> ---
(In reply to Justin L from comment #5)
> bibisect41max points to commit 1c22545edf9085b9f2656ca92781158b6b123db3
> Author:     Jian Hong Cheng
> CommitDate: Thu Mar 14 10:08:38 2013 +0100
> Fix issue #i119405 [https://bz.apache.org/ooo/show_bug.cgi?id=119405]:
> Numbering text style changed after importing the *.doc

I think the premise of this entire commit is wrong. From what I can see, it is
affecting the entire numbering style when one of the paragraphs has CR
formatting. Well, that might be fine to affect the numbering for THAT PARAGRAPH
based on the CR, but it shouldn't affect the numbering attributes as a whole.

Even worse for "9037 - italics-in-para-causes-italic-numbered-list.doc", it
appears that the italics definition is coming from "[Option 1:  New Zealand
Customs Service, paragraphs 2.1 – 2.7]". But this isn't even defined in the CR.
And yet it seems to be applying the italics to the character style WW8Num1z0 -
and so it affects every numbering on level one.

But quite honestly, I can't follow the code at all - even in a debugger. So I
have little confidence that I understand what is really happening. But my
impression is that this commit is almost entirely wrong, and should be
completely reverted (except for the two Ignore functions that are being re-used
for layout - which is where this is being handled for DOCX anyway, and possibly
even for DOC).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210309/b2a9ca02/attachment-0001.htm>