[Libreoffice-bugs] [Bug 116758] background color of frame is missing

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=116758

Justin L <jluth at mail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTOURBUG
           Hardware|x86-64 (AMD64)              |All
             Status|NEW                         |RESOLVED
                 CC|                            |jluth at mail.com

--- Comment #6 from Justin L <jluth at mail.com> ---
repro 7.2+

Armin's 4.4 commit identified in comment 5
(https://cgit.freedesktop.org/libreoffice/core/commit/?id=6e61ecd09679a66060f932835622821d39e92f01)
was the one that mostly introduced the change from RES_BACKGROUND to
XATTR_FILL_*. It was a massive change that was brilliant, but also left a lot
of loose ends. (Well, this is a Microsoft generated file, so not necessarily a
loose end.)

Adding a background and roundtripping it works.  (Not surprising, since we are
adding an XATTR_FILL properties and not RES_BACKGROUND properties now.)
<style:style style:name="fr2" style:family="graphic"
style:parent-style-name="Graphics">
  <style:graphic-properties fo:background-color="#ffb66c"
style:background-transparency="0%" draw:fill="solid" draw:fill-color="#ffb66c"
draw:opacity="100%"


Comment 0's file only has these relevant parts:
<style:style style:family="graphic" style:name="a0"
style:parent-style-name="Graphics">
<style:graphic-properties fo:background-color="#ffff00 draw:opacity="100%"

sw/source/core/unocore/unoframe.cxx
if(bSvxBrushItemPropertiesUsed && !bXFillStyleItemUsed) returns false,
because draw:opacity is considered an xFillStyle, while background-color is a
BrushItem.

Removing draw:opacity="100%" "fixes" the problem.

Using LO 3.5, I round-tripped the file and the transparency saved as
style:background-transparency="0%" - i.e. not draw: opacity.

So, Microsoft is mixing (or better yet - missing) attributes here. Probably
best to call this NOTOURBUG? It would work in both old and new LO if Microsoft
added draw:fill and draw:fill-color.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210318/123f3680/attachment.htm>