[Libreoffice-bugs] [Bug 142113] New: FILEOPEN PPTX horizontal/vertical lines are not horizontal/vertical after import

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=142113

            Bug ID: 142113
           Summary: FILEOPEN PPTX horizontal/vertical lines are not
                    horizontal/vertical after import
           Product: LibreOffice
           Version: 7.2.0.0.alpha0+ Master
          Hardware: x86-64 (AMD64)
                OS: Windows (All)
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: Impress
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: rb.henschel at t-online.de

Created attachment 171673
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171673&action=edit
Document with horizontal and vertical line

If a line is horizontal or vertical in pptx, they are not horizontal or
vertical after opening the file in Impress. The angles are slightly off. You
get 359.99deg for a horizontal line and 270.01deg for a vertical line for
example.

Besides looking at the rotation angle in the Position&Size dialog, you will
notice the error in the status bar, if the line is selected. The shown text
should include "horizontal" or "vertical", but it doesn't.

This slight deviation cancels out the horizontal/vertical detection, which is
used in several places in the code.

The error is likely in the part
https://opengrok.libreoffice.org/xref/core/oox/source/drawingml/shape.cxx?r=2a70cfb0#844
The handling of lines there is questionable:
* A line has exactly two points and one polygon. No need for a loop.
* The 'Guard against zero width or height' is wrong. A vertical line has zero
width and a horizontal line has zero height. The current solution prevents
vertical and horizontal lines. Even height and width zero at the time is
possible. Such zero length lines are visible, if line caps are set.
* What is the purpose of 'xModelInfo' there?

But I have not tested yet, whether a fix there would solve the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210506/0ebac6f2/attachment-0001.htm>