[Libreoffice-bugs] [Bug 92620] Password protected Macro length limited

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=92620

Mike Kaganski <mikekaganski at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heiko.tietze at documentfounda
                   |                            |tion.org
           Hardware|x86-64 (AMD64)              |All
           Keywords|                            |easyHack
                 OS|Windows (All)               |All

--- Comment #8 from Mike Kaganski <mikekaganski at hotmail.com> ---
The timeline of this issue:

1. In 2006 (during OOo 2.2 release cycle), in
https://bz.apache.org/ooo/show_bug.cgi?id=64377, Noel Power had implemented a
new binary image format (v.0x12 - see basic/source/inc/filefmt.hxx) that is
able to store more than 64K data (there are 38 commits returned by 'git log
--grep i64377'). At that time, it was decided that, although the new format can
fix this problem, they will *not* store it to ODF because it would be
backward-incompatible. The import code was made able to read the new format,
though - to be compatible with *some* future OOo version that starts writing
that format. The error message (warning) was implemented, as documented in
http://specs.openoffice.org/scripting_framework/BasicImageSizeIncreaseWarning.odt.
All OOo/LO/AOO versions since 2006 are thus able to read binary format 0x12.

2. In 2015 (during LO 5.1 release cycle), in tdf#94617, Laurent Godard had
implemented yet another incompatible change to the binary format (v.0x13) that
fixed a problem in previous format that procedures could only start in the
first 64K of the binary image
(https://git.libreoffice.org/core/+/ddb45261590939d884ac2bcb1fd258de7b2370da).
That made the new image in LO incompatible with all older LO versions, as well
as with all OOo/AOO versions.

3. In 2016 (during LO 5.2 release cycle), in tdf#87530, Michael Stahl made the
*new* binary image format to actually write to ODF
(https://git.libreoffice.org/core/+/6a351c5cf91d0f667168d834ba2eb5c04121c7d5).
Possibly this was an unintended side effect. Since then, the warning displayed
by LibreOffice (starting with "Error saving..."!) is in fact *wrong*, since
confirming it (pressing OK) in fact saves the encrypted module and binary
image, and all LO versions since LO 5.0.3 are able to run it.

The problems here:

1. Clarify the warning, to make it clear that only *old* versions of LO would
be unable to use the big module.
2. Possibly change the fix to tdf#94617, so that image version 0x13 is only
written when needed (i.e., when there actually is a procedure starting at
offset greater than 64K), and use version 0x12 otherwise, so that when
possible, the encrypted library is usable in all OOo/AOO/LO versions starting
from OOo 2.2 (this is a task for a separate report).

This one (about clarification of the existing message) is an easy hack related
to UI; I hope Heiko could mentor it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210520/29ec32da/attachment.htm>