[Libreoffice-bugs] [Bug 139633] Direct editing of tree nodes in the Navigator to rename objects

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=139633

--- Comment #11 from Jim Raykowski <raykowj at gmail.com> ---
Hi Tarun,

(In reply to Tarun Sharma from comment #10)
> hi jim 

> for renaming DRAWOJBECT do i have to pass refernce of m_xTreeView, by adding
> a new parameter in the execute function??!
>  
> sw/source/uibase/shells/drwbassh.cxx
> 

Handling for this case will also be done in the added edit entry handler
IMPL_LINK(SwContentTree, EditedEntryHdl, const IterString&, rIterString, bool)
in sw/source/uibase/utlui/content.cxx

> How should i validate the inputs currently its using pDlg 's method
> setForbiddenChars which was created from CreateSwRenameNamedDlg .....
> 
> pDlg(pFact->CreateSwRenameXNamedDlg(m_xTreeView.get(), xNamed, xNameAccess));

Check the rIterString.second for forbidden chars. For bookmark forbidden chars
see: sw/source/uibase/inc/bookmark.hxx static constexpr OUStringLiteral
aForbiddenChars. If found, break out of the case before setting xNameAccess.

Looking forward to seeing the patch! Please submit to gerrit and add me as a
reviewer so we can discuss code there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210522/9af89d6c/attachment.htm>